1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
#![feature(plugin)]
#![plugin(clippy)]
#![deny(useless_vec)]
#[derive(Debug)]
struct NonCopy;
fn on_slice(_: &[u8]) {}
#[allow(ptr_arg)]
fn on_vec(_: &Vec<u8>) {}
struct Line {
length: usize,
}
impl Line {
fn length(&self) -> usize {
self.length
}
}
fn main() {
on_slice(&vec![]);
//~^ ERROR useless use of `vec!`
//~| HELP you can use
//~| SUGGESTION on_slice(&[])
on_slice(&[]);
on_slice(&vec![1, 2]);
//~^ ERROR useless use of `vec!`
//~| HELP you can use
//~| SUGGESTION on_slice(&[1, 2])
on_slice(&[1, 2]);
on_slice(&vec ![1, 2]);
//~^ ERROR useless use of `vec!`
//~| HELP you can use
//~| SUGGESTION on_slice(&[1, 2])
on_slice(&[1, 2]);
on_slice(&vec!(1, 2));
//~^ ERROR useless use of `vec!`
//~| HELP you can use
//~| SUGGESTION on_slice(&[1, 2])
on_slice(&[1, 2]);
on_slice(&vec![1; 2]);
//~^ ERROR useless use of `vec!`
//~| HELP you can use
//~| SUGGESTION on_slice(&[1; 2])
on_slice(&[1; 2]);
on_vec(&vec![]);
on_vec(&vec![1, 2]);
on_vec(&vec![1; 2]);
// Now with non-constant expressions
let line = Line { length: 2 };
on_slice(&vec![2; line.length]);
on_slice(&vec![2; line.length()]);
for a in vec![1, 2, 3] {
//~^ ERROR useless use of `vec!`
//~| HELP you can use
//~| SUGGESTION for a in &[1, 2, 3] {
println!("{:?}", a);
}
for a in vec![NonCopy, NonCopy] {
println!("{:?}", a);
}
}